fix mongodb tops module for pymongo v4 compatibility#68662
Open
smartcoder0777 wants to merge 1 commit intosaltstack:masterfrom
Open
fix mongodb tops module for pymongo v4 compatibility#68662smartcoder0777 wants to merge 1 commit intosaltstack:masterfrom
smartcoder0777 wants to merge 1 commit intosaltstack:masterfrom
Conversation
a226342 to
22c2188
Compare
Author
|
@bdrx312 Can you review my PR and merge it please? |
twangboy
approved these changes
Jan 28, 2026
22c2188 to
43de121
Compare
Author
|
@twangboy It looks like the PR passed all checks. Would you merge it and close the issue? |
Author
|
@dwoz Could you merge my PR and close the issue? |
Author
|
@twangboy can you merge my PR and close the issue? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #68659
What does this PR do?
Fixes the mongodb tops module to work with pymongo v4+ by replacing the deprecated mdb.authenticate() method with authentication credentials passed directly to the MongoClient constructor.
What issues does this PR fix or reference?
Fixes #68659
Previous Behavior
The mongodb tops module used the deprecated mdb.authenticate(user, password) method which was removed in pymongo v4. This caused authentication failures when using pymongo v4.9+ (required for MongoDB v8 compatibility).
New Behavior
Authentication credentials are now passed directly to MongoClient constructor using username, password, and authSource parameters, making it compatible with both pymongo v3 and v4+.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=191128130