Allow for toggling of LDAP attribute ordering#68628
Draft
tacerus wants to merge 1 commit intosaltstack:3006.xfrom
Draft
Allow for toggling of LDAP attribute ordering#68628tacerus wants to merge 1 commit intosaltstack:3006.xfrom
tacerus wants to merge 1 commit intosaltstack:3006.xfrom
Conversation
With some LDAP implementations attributes are not stored and returned in the order in which they were added, leading to the state repeatedly reporting changes. Introduce a toggle which enables internal sorting of old and new attributes and restores idempotency in such situations. Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
bdrx312
reviewed
Jan 16, 2026
Comment on lines
-350
to
-351
| # convert the value sets to lists before returning them to the | ||
| # user (sorted for easier comparisons) |
Contributor
There was a problem hiding this comment.
This comment was removed, but sorted is still called on the output below on line 368 attr: sorted(vals).
Contributor
Author
There was a problem hiding this comment.
Thanks for the pointer, that indeed needs to go too.
Currently I have this a bit stalled because I submitted python-ldap/python-ldap#604 in parallel, and in case that gets approved, it would be nice to make strict_order support a list of attributes instead of only a general toggle. Generally the improvements here would not do much without the patch in python-ldap (besides improving the output after removing the sorted() you mention), because the change would be reported but never committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With some LDAP implementations attributes are not stored and returned in the order in which they were added, leading to the state repeatedly reporting changes. Introduce a toggle which enables internal sorting of old and new attributes and restores idempotency in such situations.
What issues does this PR fix or reference?
Fixes #68626.
Previous Behavior
Stray changes upon ordering differences.
New Behavior
No changes if ordering is not deemed relevant.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes