Bump to 3.2.3.0: relax mini_portile2 to ~> 2.5#13
Open
guilhermemsnogueira wants to merge 2 commits into
Open
Conversation
Releases the mini_portile2 ~> 2.5 relaxation (aa6aff3) so consumers can resolve mini_portile2 2.6+. This unblocks salsify_kafka >= 8.2 / rdkafka >= 0.13.1 (which require mini_portile2 ~> 2.6) in downstream apps such as puddle.
markcell
reviewed
Jul 2, 2026
| require 'mkmf' | ||
| require 'rubygems' | ||
| gem 'mini_portile2', '~> 2.5.0' # Keep this version in sync with the one in the gemspec! | ||
| gem 'mini_portile2', '~> 2.5' # Keep this version in sync with the one in the gemspec! |
There was a problem hiding this comment.
Should we change it to ~> 2.6.0? This way, we keep the current behavior of disallowing minor updates (only patches).
Note: I'm assuming 2.6 is the version we need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published
salsify_libxml_ruby(3.2.2.0) pinsmini_portile2 ~> 2.5.0. This hard-blocks any consumer that also needs a modern Kafka client:salsify_kafka >= 8.2depends onrdkafka >= 0.13.1, which requiresmini_portile2 ~> 2.6. The two constraints are mutually exclusive, so apps like puddle cannot upgrade tosalsify_kafka8.x (needed for the SimpleConsumer feature) while this gem stays at 3.2.2.0.Solution
Two commits:
aa6aff3(already on master, previously unreleased): relax themini_portile2constraint from~> 2.5.0to~> 2.5in both the gemspec andext/libxml/extconf.rb.~> 2.5admits 2.6 through 2.x, satisfying the rdkafka floor.eb32398: bump the gem version 3.2.2.0 -> 3.2.3.0 (lib/libxml/version.rb+ext/libxml/ruby_xml_version.h, which the gemspec reads) so the relaxed constraint can actually be published.Verified downstream: pointing puddle's Gemfile at this source resolves cleanly to
salsify_kafka 8.3.1,salsify_organizations 0.14.2,rdkafka 0.19.0,mini_portile2 2.8.9.Caveats/Notes
The constraint change only affects the build-time native-extension toolchain (mini_portile2 downloads/compiles vendored libxml2). No runtime XML behavior changes. Once merged and released to gems.salsify.com as 3.2.3.0, the puddle kafka-bump branch can consume it.