Skip to content

Add queue support for Barstool recordings#1

Open
niladam wants to merge 3 commits intosaloonphp:mainfrom
niladam:feature/queue-recording
Open

Add queue support for Barstool recordings#1
niladam wants to merge 3 commits intosaloonphp:mainfrom
niladam:feature/queue-recording

Conversation

@niladam
Copy link
Copy Markdown

@niladam niladam commented Mar 27, 2026

First and foremost thank you for this! Good job!

I personally, have a user-land implementation of something similar which i've built for my own personal use and because of this, i know that i don't want my requests to be affected and therefore i personally use jobs. I think it makes sense to have this as an option in this package as well, as i plan to essentially deprecate my user-land implementation in favor of this.

Also, i think that this doesn't affect the current functionality and it only adds to it's functionality :)

@craigpotter craigpotter added the enhancement New feature or request label Mar 28, 2026
Copy link
Copy Markdown
Collaborator

@craigpotter craigpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this @niladam

Just one small change

@niladam
Copy link
Copy Markdown
Author

niladam commented Mar 29, 2026

Looks great, thanks for this @niladam

Just one small change

So, while i was resolving your suggestion i realised that phpunit.xml.dist also needed some updates. And while i was looking into that i fixed a couple of failing tests (due to uniqueness);

Also, ran a quick pint on tests/BarstoolTest.php :)

We should be good to go :)

@niladam niladam requested a review from craigpotter March 29, 2026 07:58
@niladam
Copy link
Copy Markdown
Author

niladam commented Mar 29, 2026

Also, sorry for spamming this, but i didn't touch CHANGELOG thinking you're auto-generating it. If that's not the case we should probably update that as well :)

@craigpotter
Copy link
Copy Markdown
Collaborator

Also, sorry for spamming this, but i didn't touch CHANGELOG thinking you're auto-generating it. If that's not the case we should probably update that as well :)

No worries @niladam.

This is looking good. No need to worry about the change log, I'll handle this.

I will give it and quick blast this evening and if all good - I'll release and tag a new version.
Thanks for this !!!!

@niladam
Copy link
Copy Markdown
Author

niladam commented Mar 30, 2026

Also, sorry for spamming this, but i didn't touch CHANGELOG thinking you're auto-generating it. If that's not the case we should probably update that as well :)

No worries @niladam.

This is looking good. No need to worry about the change log, I'll handle this.

I will give it and quick blast this evening and if all good - I'll release and tag a new version. Thanks for this !!!!

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants