Conversation
* Major refactoring in support of concurrency checking - included backward breaking changes. * Adopt swift testing.
toddheasley
requested changes
Jun 26, 2024
Collaborator
toddheasley
left a comment
toddheasley
left a comment
There was a problem hiding this comment.
This is awesome. Test scheme doesn't run all the tests, see my note. Any reason to not bump everything to Swift 6, even though it's pre-release?
| func testHorizontalUncertainty() { | ||
| var location = CLLocation(coordinate: .pointNemo) | ||
| XCTAssertNil(location.horizontalUncertainty) | ||
| struct CLLocationTests { |
Collaborator
There was a problem hiding this comment.
For these nested test suites, the enclosing struct needs @Suite annotation if it doesn't (directly) contain any @Tests
I was wondering why the ef those weren't running,
Contributor
Author
Not really, I just wanted to try it one step at a time. |
Contributor
Author
|
It may be a while before GitHub actions supports macOS 15, so the tests won't build until then. Hopefully once the public betas are out. |
toddheasley
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major refactoring that enables strict concurrency checking.
It introduces backward breaking changes that will require a major version bump.
The largest change is that the formatters can now only be configured upon initialization, so this settings become immutable.
Other changes include the adoption of the new Swift Testing framework. This requires Xcode 16.