Skip to content

fix MediaMuxer start/close fail, caused by race condition #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leexugang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix MediaMuxer start/close fail, caused by race condition #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/java/com/serenegiant/encoder/MediaMuxerWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public class MediaMuxerWrapper {

private String mOutputPath;
private final MediaMuxer mMediaMuxer; // API >= 18
private int mEncoderCount, mStatredCount;
private boolean mIsStarted;
private volatile int mEncoderCount, mStatredCount;
private volatile boolean mIsStarted;
private MediaEncoder mVideoEncoder, mAudioEncoder;

/**
Expand Down Expand Up @@ -167,8 +167,12 @@ public synchronized boolean isStarted() {
* @param bufferInfo
*/
/*package*/ synchronized void writeSampleData(final int trackIndex, final ByteBuffer byteBuf, final MediaCodec.BufferInfo bufferInfo) {
if (mStatredCount > 0)
try {
mMediaMuxer.writeSampleData(trackIndex, byteBuf, bufferInfo);
} catch (final Exception e) {
stopRecording();
Log.e(TAG, "writeSampleData fail:" + trackIndex + e);
}
}

//**********************************************************************
Expand Down