Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/PR inline comments/.DS_Store
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed from PR

Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
comment_id,polarity,text,created_at_gold,author_login,owner,repo,review_id,html_url,created_at_kaiaulu,updated_at,comment_user_login,author_association,file_path,start_line,line,original_start_line,original_line,position,diff_hunk,body,commit_id
2386669,1,"that would be great, thanks, can't find any documentation on this feature.""",2012-12-11 12:27:48,jberkel,JakeWharton,ActionBarSherlock,,https://github.com/JakeWharton/ActionBarSherlock/pull/736#discussion_r2386669,2012-12-11T23:27:48Z,2012-12-11T23:27:48Z,jberkel,NONE,library/src/com/actionbarsherlock/app/SherlockActivity.java,,22.0,,,11,"@@ -18,6 +19,7 @@
import com.actionbarsherlock.view.MenuInflater;
import com.actionbarsherlock.view.MenuItem;

+@TargetApi(11)","that would be great, thanks, can't find any documentation on this feature.
",10a82cde65d4b063c5512b38a19652bbe9f32793
2379700,0,"This is wrong since it works on API 7+""",2012-12-11 04:51:21,JakeWharton,JakeWharton,ActionBarSherlock,,https://github.com/JakeWharton/ActionBarSherlock/pull/736#discussion_r2379700,2012-12-11T15:51:21Z,2012-12-11T15:51:21Z,JakeWharton,OWNER,library/src/com/actionbarsherlock/app/SherlockActivity.java,,22.0,,,11,"@@ -18,6 +19,7 @@
import com.actionbarsherlock.view.MenuInflater;
import com.actionbarsherlock.view.MenuItem;

+@TargetApi(11)","This is wrong since it works on API 7+
",10a82cde65d4b063c5512b38a19652bbe9f32793
2389775,1,"i build my project using maven so there is no ABS library folder per se (get recreated for each build) so this might not be applicable. thanks for your help anyway!""",2012-12-11 21:17:34,jberkel,JakeWharton,ActionBarSherlock,,https://github.com/JakeWharton/ActionBarSherlock/pull/736#discussion_r2389775,2012-12-12T08:17:34Z,2012-12-12T08:17:34Z,jberkel,NONE,library/src/com/actionbarsherlock/app/SherlockActivity.java,,22.0,,,11,"@@ -18,6 +19,7 @@
import com.actionbarsherlock.view.MenuInflater;
import com.actionbarsherlock.view.MenuItem;

+@TargetApi(11)","i build my project using maven so there is no ABS library folder per se (get recreated for each build) so this might not be applicable. thanks for your help anyway!
",10a82cde65d4b063c5512b38a19652bbe9f32793
Expand Down
6,514 changes: 6,514 additions & 0 deletions data/PR inline comments/akka_sentiment_pr_inline_comments_joined.csv

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
comment_id,polarity,text,created_at_gold,author_login,owner,repo,review_id,html_url,created_at_kaiaulu,updated_at,comment_user_login,author_association,file_path,start_line,line,original_start_line,original_line,position,diff_hunk,body,commit_id
1664046,0,"`GitHubAccountAuthenticator` sounds reasonable.""",2012-09-21 06:10:53,kevinsawicki,github,android,,https://github.com/pockethub/PocketHub/pull/224#discussion_r1664046,2012-09-21T18:10:53Z,2012-09-21T18:50:50Z,kevinsawicki,CONTRIBUTOR,app/src/main/java/com/github/mobile/accounts/AccountAuthenticator.java,,,,,1,"@@ -75,7 +85,58 @@ public Bundle editProperties(AccountAuthenticatorResponse response,
public Bundle getAuthToken(AccountAuthenticatorResponse response,
Account account, String authTokenType, Bundle options)
throws NetworkErrorException {
- return null;
+
+ final Bundle bundle = new Bundle();
+
+ if(!authTokenType.equals(ACCOUNT_TYPE)) return bundle;
+
+ AccountManager am = AccountManager.get(context);
+ String username = account.name;
+ String password = am.getPassword(account);
+
+ String authToken = null;
+ DefaultClient client = new DefaultClient();
+ client.setCredentials(username, password);
+
+ OAuthService oAuthService = new OAuthService(client);
+
+ // Get authorizations for app if they exist
+ try {
+ try {
+ List<Authorization> auths = oAuthService.getAuthorizations();
+ for(Authorization auth : auths)
+ if(auth.getApp().getName().equals(ACCOUNT_NAME))
+ authToken = auth.getToken();
+ }
+ catch ( NullPointerException npe ) { }
+
+ // Setup authorization for app if others didn't exist.
+ if(TextUtils.isEmpty(authToken)) {
+ Authorization auth = oAuthService.createAuthorization(
+ new Authorization().setNote(ACCOUNT_NAME).setUrl(APP_URL)
+ );
+ if(auth != null) authToken = auth.getToken();
+ }
+
+ // If couldn't get authToken
+ if(TextUtils.isEmpty(authToken)) {
+ final Intent intent = new Intent(context, LoginActivity.class);
+ intent.putExtra(PARAM_AUTHTOKEN_TYPE, ACCOUNT_TYPE);
+ intent.putExtra(KEY_ACCOUNT_AUTHENTICATOR_RESPONSE, response);
+ bundle.putParcelable(KEY_INTENT, intent);
+ return bundle;
+ }
+
+ // Assemble and return bundle
+ bundle.putString(AccountManager.KEY_ACCOUNT_NAME, account.name);
+ bundle.putString(AccountManager.KEY_ACCOUNT_TYPE, ACCOUNT_TYPE);
+ bundle.putString(AccountManager.KEY_AUTHTOKEN, authToken);
+
+ // Clear password from account
+ am.clearPassword(account);
+ return bundle;
+ } catch ( Exception e ) { e.printStackTrace(); }","`GitHubAccountAuthenticator` sounds reasonable.
",e70b701b4b7bd5e2dc5cc00ba82605689c3723fb
1663939,1,"Yes! I'll do that. On Fri, Sep 21, 2012 at 12:57 PM, Kevin Sawicki <notifications@github.com>wrote: > In app/src/main/java/com/github/mobile/AuthorizationClient.java: > > > @@ -0,0 +1,68 @@ > > +/* > > This class can be removed now right? > >""",2012-09-21 06:00:32,TrevorBasinger,github,android,,https://github.com/pockethub/PocketHub/pull/224#discussion_r1663939,2012-09-21T18:00:32Z,2012-09-21T18:50:50Z,TrevorBasinger,CONTRIBUTOR,app/src/main/java/com/github/mobile/AuthorizationClient.java,,,,,1,"@@ -0,0 +1,68 @@
+/*","Yes! I'll do that.

On Fri, Sep 21, 2012 at 12:57 PM, Kevin Sawicki notifications@github.comwrote:

> In app/src/main/java/com/github/mobile/AuthorizationClient.java:
>
> > @@ -0,0 +1,68 @@
> > +/*
>
> This class can be removed now right?
>
> —
> Reply to this email directly or view it on GitHubhttps://github.com/github/android/pull/224/files#r1663907.
",e70b701b4b7bd5e2dc5cc00ba82605689c3723fb
1222306,2,"Shame on me. You are absolutely right. I reworked the commit according to your comments.""",2012-07-23 17:37:37,Bananeweizen,github,android,,https://github.com/pockethub/PocketHub/pull/145#discussion_r1222306,2012-07-24T05:37:37Z,2012-07-24T05:37:37Z,Bananeweizen,CONTRIBUTOR,app/src/main/java/com/github/mobile/ui/commit/DiffStyler.java,,,,,1,"@@ -72,7 +72,10 @@ public DiffStyler setFiles(final Collection<CommitFile> files) {
StyledText styled = new StyledText();
while (end != -1) {
String line = patch.substring(start, end + 1);
- switch (patch.charAt(start)) {
+ if (line.length() == 0) {
+ continue;","Shame on me. You are absolutely right. I reworked the commit according to your comments.
",d1e578a144299d4a7e1cfcc1705f6d4502152f91
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
comment_id,polarity,text,created_at_gold,author_login,owner,repo,review_id,html_url,created_at_kaiaulu,updated_at,comment_user_login,author_association,file_path,start_line,line,original_start_line,original_line,position,diff_hunk,body,commit_id
15859,2,"ok, sorry""",2011-04-05 21:59:44,andreialecu,AutoMapper,AutoMapper,,https://github.com/LuckyPennySoftware/AutoMapper/pull/29#discussion_r15859,2011-04-06T09:59:44Z,2011-04-06T10:01:28Z,andreialecu,CONTRIBUTOR,src/AutoMapper/Mappers/CollectionMapper.cs,,55.0,,,11,"@@ -48,11 +48,25 @@ namespace AutoMapper.Mappers

protected override TCollection CreateDestinationObjectBase(Type destElementType, int sourceLength)
{
- var list = typeof(TCollection).IsInterface
- ? new List<TElement>()
- : ObjectCreator.CreateDefaultValue(typeof (TCollection));
+ Object collection;
+
+ if (typeof(TCollection).IsInterface)
+ {
+ if (typeof(TCollection).Name == ""ISet`1"")","A strong typed alternative to this would be:

```
if (typeof (TCollection).GetGenericTypeDefinition() == typeof (ISet<>))
```
",5492f5c2ed075c609e90c788ff4d43e97539cc4d
Expand Down
Loading