Open
Conversation
kryptx
force-pushed
the
handle-non-200-success-codes
branch
from
fa8abf4 to
afddfdc
Compare
m1dcarry
reviewed
May 18, 2021
| }) | ||
| .reply(201, {/* don't care about response */}); | ||
|
|
||
| test.expect(2); |
There was a problem hiding this comment.
It's not clear to me as to why we are expecting 2 here? Shouldn't it be expecting 1 because we are only creating a single watch?
Author
There was a problem hiding this comment.
The number is how many assertions nodeunit should expect. I've mainly just done this to follow the pattern elsewhere in this repo :)
There was a problem hiding this comment.
Ah right okay. I misunderstood that! thanks
m1dcarry
approved these changes
May 18, 2021
ben833
approved these changes
Sep 23, 2021
Contributor
ben833
left a comment
ben833
left a comment
There was a problem hiding this comment.
Please update the version before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the client to handle success codes other than 200.