It's escape = now, not quote_escape =#16
Open
jennybc wants to merge 1 commit intosahilseth:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
quote_escapeargument will be removed fromreadr::write_*()in its next release. It has been deprecated for over 4 years, since readr v2.0.0 (2021-07-20). Since that time, anyquote_escapevalue has just been passed along asescape, which is what this PR does.This is part of a bigger effort to advance a bunch of deprecation processes that started 4+ years ago: tidyverse/readr#1600. I released readr v2.1.6 on 2025-11-14 and have no immediate plans for another release. I just wanted to advance these deprecations right away, to give downstream dependencies plenty of time to adjust.
I am also sending an email to the maintainer listed in DESCRIPTION.