Prefer glue_data() when data might be list-ish, not an actual environment#15
Open
jennybc wants to merge 2 commits intosahilseth:masterfrom
Open
Prefer glue_data() when data might be list-ish, not an actual environment#15jennybc wants to merge 2 commits intosahilseth:masterfrom
glue_data() when data might be list-ish, not an actual environment#15jennybc wants to merge 2 commits intosahilseth:masterfrom
Conversation
Add the final 's' to 'allowEscapes'
Author
|
I released glue 1.7.0 today without this change and then re-introduced the change. So you can expect it to be present in glue's next release, which I have no concrete plans for. But barring an unforeseen release in the next ~2 weeks, I will consider this issue as me having given plenty of notice of the change. This also means you can check your package in the presence of dev glue to test your own fix for the issue. |
16 tasks
Author
|
glue 1.8.0 has been accepted on CRAN now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is inspired by doing revdep checks for glue. I'm going to temporarily back off on the associated change in glue, just so I can release without any breakage of other packages.
But please do consider this a heads up that, in the future,
glue::glue()will error when.enviris not an actual environment..envirhas always been documented to be an environment and I'd like to make that actually true.OTOH
glue_data()does officially accept something "list-ish" as.x. So I think it's a better choice for your usage.Backstory in glue:
tidyverse/glue#308
tidyverse/glue@e2b74ff