Repository navigation
fix(release): recover image publishing for already-published releases - #117
Merged
Merged
Conversation
- plan: wait for the main CI run for the release commit instead of failing the ci-gate when a dispatch outruns CI (v0.29.0 failure: plan died at 23:05Z while CI only succeeded at 23:08Z) - stage: a release published by release-please but still assetless falls through to staging the built assets instead of dying in gh release download (v0.30.0 failure: no assets to download) - container: run the container job whenever stage succeeds, not only for unpublished releases; docker.yml manifest is retry-safe and reuses an existing version tag after verifying the source sha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The v0.29.0 and v0.30.0 GitHub releases exist, but no container images were published for them (GHCR stops at 0.28.0). Two distinct failures in release.yml, plus a structural gap:
the exact release commit has no successful main push CI run; CI only succeeded 23:08:15Z). Once release-please had created the release, later workflow_run passes reported created=false and never retried the publish.gh release downloadwithno assets to download(02:29:38Z). The duplicate tag-push run was also cancelled with zero jobs, leaving no surviving publish path.stage.outputs.published != true, so a release whose assets are complete but whose image was never pushed could not be recovered by re-running release.yml: publish would look up a nonexistent image tag.Changes (release.yml only)
Recovery for v0.30.0 / v0.29.0
LICENSE and NOTICE (taken from each tag) were added to both releases; their uploaded asset sets now pass
release_tools.py verify(14 files). After this merges, re-dispatching release.yml with dry_run=false for v0.30.0 (and v0.29.0 as a backfill) publishes the missing images and repairs the latest / minor aliases.