Open
Conversation
just checking
throw messege works too
help us to generate new ID that we know for sure isn't exist
In, addition the generate uniqe ID works for this two functions
used at playSong function
should to conver from mm:ss format to seconds
added the songs:[] property neacuse this is how a cell in the array should look like
the problem was that, when we used the function removeSong the song was remove from the songs object and the playlist, the new function fixed that
ShaharEli
reviewed
Sep 13, 2021
| ], | ||
| playSong(song) { | ||
| console.log(/* your code here */) | ||
| console.log( |
| for (let i = 0; i < player.songs.length; i++) { | ||
| //runs on the songs array | ||
| if (player.songs[i].id === id) { | ||
| player.playSong(player.songs[i]) |
|
|
||
| function editPlaylist(playlistId, songId) { | ||
| // your code here | ||
| if (!checkId(player.songs, songId)) |
There was a problem hiding this comment.
maybe move this logic to a function?
| for (let i = 0; i < player.songs.length; i++) { | ||
| //for songs | ||
| if ( | ||
| player.songs[i].album.toUpperCase().includes(tempQuery) || |
There was a problem hiding this comment.
move to a function or put all the fields you want to check to array and loop through them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was lovely 👍