Reproduce bug where dst leap is passed on to subsequent occurences#647
Open
schreven wants to merge 1 commit intosabre-io:masterfrom
Open
Reproduce bug where dst leap is passed on to subsequent occurences#647schreven wants to merge 1 commit intosabre-io:masterfrom
schreven wants to merge 1 commit intosabre-io:masterfrom
Conversation
Contributor
|
@schreven thanks for the test cases. But then that daily event gets scheduled at 0315 on the following days, which is not correct. The event should happen at 0215 (now on the "summer time" clock). Do you have a suggested fix? |
Author
|
Hey @phil-davis, yes you summarized the issue perfectly. I see that you spotted the issue I created #648 and I continued the discussion there. Thank you for this library, it's a nice piece of software |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of issue #648