Conversation
cdf8031 to
9b9057d
Compare
fa32383 to
4346302
Compare
Owner
Author
82b1fa7 to
8f58f94
Compare
c525b08 to
70c9bdb
Compare
b284cef to
c70100c
Compare
4c6f27f to
0221da9
Compare
9c0601e to
04e20be
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds a new Tauri-based desktop UI application for log parsing (ui-tauri), integrates its build and publish workflows, refactors core decoding and serialization logic, and updates documentation and workspace configuration.
- Introduces
ui-taurifolder with frontend scaffolding, editor settings, Prettier config, and GitHub workflows for Android and desktop releases - Refactors
ezlog-core: removes short JSON field renames, rewrites record decoding, adds inline helpers, and updates default features - Updates docs (examples and sidebar),
CHANGELOG.md, and workspace/Cargo.toml to include UI app
Reviewed Changes
Copilot reviewed 20 out of 140 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui-tauri/index.html | Basic HTML template for Tauri UI |
| ui-tauri/README.md | Dev setup and IDE recommendations for the UI |
| ui-tauri/.vscode/extensions.json | VS Code extension recommendations |
| ui-tauri/.prettierrc | Prettier rules for the UI code |
| ui-tauri/.gitignore | Ignore patterns for UI build artifacts and logs |
| ezlog-core/src/recorder.rs | Removed serde(rename) attributes from EZRecord fields |
| ezlog-core/src/logger.rs | Added #[inline] annotations and new helper methods |
| ezlog-core/src/decode.rs | Rewrote decode_record, changed header decoding, updated tests |
| ezlog-core/Cargo.toml | Disabled default JSON feature |
| docs/src/query.md | Added instructions for UI log viewer |
| docs/src/platform/*.md | Expanded code examples for Rust, iOS, Android, Flutter |
| docs/src/SUMMARY.md | Updated sidebar to include "Log query" |
| Cargo.toml | Added ui-tauri/src-tauri to workspace, commented release flags |
| CHANGELOG.md | Documented new UI application and workflow support |
| .github/workflows/setup-android/action.yml | Composite action for Android SDK/NDK setup |
| .github/workflows/publish_tauri.yml | Workflow for building and publishing the Tauri app |
| .github/workflows/build_test.yml | Adjusted Clippy commands in CI |
Comments suppressed due to low confidence (5)
ezlog-core/src/recorder.rs:29
- Removing the
serde(rename)attribute here changes the JSON key from the short form tolog_name, breaking existing JSON consumers. Consider restoring the#[cfg_attr(feature = "json", serde(rename = "n"))]to maintain backward compatibility.
log_name: String,
docs/src/query.md:5
- [nitpick] Grammatical correction: change
it support decompress and decrypttoit supports decompressing and decrypting.
If you want view a log file, you can use cmdline tools to parse the log, and open the output file in any text viewer application. Or you can download ezlog-ui application which is a desktop app built by tauri, it support decompress and decrypt.
.github/workflows/setup-android/action.yml:40
- Appending the raw path to
GITHUB_PATHwon't update thePATHenvironment variable correctly. You need to prependPATH=and include existing$PATH(e.g.,echo "PATH=$ANDROID_HOME/...:$PATH" >> $GITHUB_PATH).
echo "$ANDROID_HOME/build-tools/${{ inputs.build-tools-version }}" >> $GITHUB_PATH
ezlog-core/src/decode.rs:280
Headerhas nois_none()method—this call will not compile. Useis_empty()or check against a sentinel version instead ofis_none().
if header.is_none() || header.is_unknown() {
ezlog-core/src/decode.rs:387
- Replacing
expectwithunwrap_or_elseswallows send errors silently, so failures in signaling won't be caught as test errors. Consider restoringexpector returning a test failure.
tx.send(()).unwrap_or_else(|_| {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tauri android publish tauri-apps/tauri-action#525 (comment)