Major refactor of the project #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-heppner
force-pushed
the
Refactor/model
branch
2 times, most recently
from
e1f0606 to
dd6792a
Compare
Currently, we can only effectively use the `SemanticMatch` and `EquivalenceTable` classes with the server. This structure was not very effective for testing. We refactor away from using the model and instead add a new `algorithm` module. Semantic matches are now stored in a `networkx.DiGraph`, a directed graph. The algorithm is performed on the graph with effective graph operations, making the whole process more efficient as well. Furthermore, we clean up the service to use it in a more pythonic way, eliminating the need for the `service_model` module. Note, that this is a major refactor and solves multiple problems: Fixes #1 Fixes #5
s-heppner
force-pushed
the
Refactor/model
branch
from
dd6792a to
f7c4a6c
Compare
s-heppner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can only effectively use the
SemanticMatchandEquivalenceTableclasses with the server. This structure wasnot very effective for testing. We refactor away from using the
model and instead add a new
algorithmmodule.Semantic matches are now stored in a
networkx.DiGraph, adirected graph. The algorithm is performed on the graph with
effective graph operations, making the whole process more
efficient as well.
Furthermore, we clean up the service to use it in a more pythonic
way, eliminating the need for the
service_modelmodule.Note, that this is a major refactor and solves multiple problems:
Fixes #1
Fixes #5