parser.py: Allow equal signs in field values #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parser did not account for the possibility of equal
signs (`=`) in the values of fields and would result in crashing the
script with a non descriptive error message, due to expecting a simple
`string.split("=")` to work.
However, it is completely possible to have equal signs in the value,
for example in an URL field: `URL = "https://example.org/query?x=1"`.
This adapts the parsing logic, making it stable against equal signs in
field values. Furthermore, it cleans up the `BibTeXEntry.from_string`
method a little bit and adds additional test cases to the unittests.
Fixes #3
s-heppner
force-pushed
the
fix/field_values_with_equal_signs
branch
from
ceb0613 to
9ad2f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parser did not account for the possibility of equal signs (
=) in the values of fields and would result in crashing the script with a non descriptive error message, due to expecting a simplestring.split("=")to work.However, it is completely possible to have equal signs in the value, for example in an URL field:
URL = "https://example.org/query?x=1".This adapts the parsing logic, making it stable against equal signs in field values. Furthermore, it cleans up the
BibTeXEntry.from_stringmethod a little bit and adds additional test cases to the unittests.Fixes #3