--> constructror(+UndergraduateStudent -- +Student)#2
Merged
Conversation
rzr8i
requested changes
May 18, 2025
Owner
rzr8i
left a comment
There was a problem hiding this comment.
Both constructors need to be public.
fill them and fix
rzr8i
requested changes
May 18, 2025
| throw new UnsupportedOperationException("Unimplemented method 'getStudentDetails'"); | ||
| } | ||
|
|
||
| public GraduateStudent(String studentId,String firstName,String lastName,String major,String superString,String theString) |
Owner
There was a problem hiding this comment.
Suggested change
| public GraduateStudent(String studentId,String firstName,String lastName,String major,String superString,String theString) | |
| public GraduateStudent(String studentId,String firstName,String lastName,String major,String supervisor,String thesisTitle) |
rzr8i
requested changes
May 18, 2025
Owner
rzr8i
left a comment
There was a problem hiding this comment.
- Implement a constructor for
Loanand set Loan's properties. - Change getters to return those properties.
Owner
There was a problem hiding this comment.
Getters should return a value!
You should implement a constructor for Loan to initialize the variables. and then return them in the getter methods.
for example:
public Student getStudent() {
return this.student;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.