fix(docs-site): patch elm-pages base path for GitHub Pages#30
Merged
Conversation
The elm-pages v3.5.1 --base flag has a bug: the generated urlToRoute function doesn't strip the base path before matching routes, causing all pages to pre-render as "Page not found." This patch fixes the codegen to inline the base path stripping logic into urlToRoute. Also simplifies the CI workflow — the patched build outputs files at the dist root with correct /devtools/ prefixed links, so we just upload dist/ directly instead of restructuring the output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlToRoutenot stripping the base path (causing all pages to pre-render as "Page not found")This is a follow-up to #29 which configured the base path but hit an elm-pages bug where the pre-renderer couldn't match routes.
What was wrong
elm-pages'
--base /devtools/flag correctly setsbaseUrlfor link generation, but the generatedurlToRoutefunction passes the full URL path (e.g.,/devtools/docs/getting-started) directly tosegmentsToRoutewithout stripping the base prefix first. Every route match fails, so all pages pre-render as "Page not found."The fix
A
pnpm patchonelm-pages@3.5.1that inlines base-path stripping into theurlToRoutecodegen, so the generated function becomes:Test plan
🤖 Generated with Claude Code