LexiconfreeLabelsyncBeamSearch: Multi-scorer functionality with intermediate pruning#207
Open
SimBe195 wants to merge 7 commits into
Open
LexiconfreeLabelsyncBeamSearch: Multi-scorer functionality with intermediate pruning#207SimBe195 wants to merge 7 commits into
SimBe195 wants to merge 7 commits into
Conversation
…eeLabelsyncBeamSearch
hannah220
reviewed
Apr 27, 2026
| auto const& scoreAccessor = scoreAccessors[hypIndexToContextIndexMap_[hypIndex]]; | ||
|
|
||
| if (not scoreAccessor) { | ||
| // No extensions for hyps that couldn't be scored |
Contributor
There was a problem hiding this comment.
Suggested change
| // No extensions for hyps that couldn't be scored | |
| // No extensions for hyps that can be scored |
Collaborator
Author
There was a problem hiding this comment.
I don't understand. When the scoreAccessor is None (i.e. the hyp couldn't be scored), it's skipped.
larissakl
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LexiconfreeTimesyncBeamSearchandTreeTimesyncBeamSearchalgorithms already have support for multiple LabelScorers applied one after another with intermediate pruning in-between.LexiconfreeLabelsyncBeamSearchon the other hand only supports a single LabelScorer as of now. This PR adds this missing functionality to it.The implementation already incorporates pre-pruning like in #199.