Conversation
…mesyncBeamSearch`
hannah220
requested changes
Jan 8, 2026
hannah220
reviewed
Jan 9, 2026
hannah220
approved these changes
Jan 12, 2026
curufinwe
requested changes
Jan 13, 2026
Contributor
curufinwe
left a comment
There was a problem hiding this comment.
Looks OK to me. In mainly looked at the interfaces and parameter names and did not thoroughly look at the changes to the search algorithm. I only have 1 request for changes (add logging) and one clarification question.
hannah220
requested changes
Jan 14, 2026
hannah220
approved these changes
Feb 2, 2026
larissakl
approved these changes
Feb 5, 2026
Contributor
|
Maybe we should also adjust the documentation at the begin of the search algorithms. At the moment it says "Uses a LabelScorer to context initialization/extension and scoring.". I would maybe somehow mention that one can use multiple LabelScorers with intermediate pruning. |
Co-authored-by: larissakl <56513675+larissakl@users.noreply.github.com>
curufinwe
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option to configure multiple label scorers with intermediate pruning after each one in
LexiconfreeTimesyncBeamSearchandTreeTimesyncBeamSearch. This is for efficiency gains so that for example when searching with CTC + LSTM LM some pre-pruning can be done based on the CTC scores before doing the more expensive LSTM calculations.Speech::ModelCombinationhas a new parameternum-label-scorersand then builds a list of LabelScorers of that size. The search algorithms then use this list and iteratively score extensions and apply intermediate pruning for each scorer in this list in thedecodeStep. To this end, themax-beam-sizeandscore-thresholdconfig parameters were changed fromParameterIntandParameterFloattoParameterIntVectorandParameterFloatVector. For example with 3 LabelScorers the order of steps would be: