Closed
Conversation
Member
|
I don't think we should do this, at least not this way, as doing so would mean we fail to parse the entire cookie if the date is < 1601, which would violate the spec (only the expires / date field should fail to parse). The question of whether the date should or shouldn't parse if the year is < 1601 is a tricky one. Obviously according to the spec, it should fail to parse. Chrome, however, allows it and returns a "minimal time". Firefox accepts it. The The fix to offset is correct, however. |
Member
|
Correct fixes merged in ff615ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6265, Page 15