Open
Conversation
Clarify that tls.mutual.ca_certs accepts CA certificate bundles, including concatenated CA chains, and align the MtlsConfig API docs with the guide wording. Closes rwf2#2938.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the mTLS
ca_certsdocumentation to describe CA certificate bundles instead of only a single certificate chain.What Changed
tls.mutual.ca_certsaccepts CA certificatesrocket::mtls::MtlsConfigAPI docs with the guide wordingValidation
git diff --checkcargo +nightly-aarch64-apple-darwin doc -p rocket --features mtls --no-depsNotes
The targeted
rocketAPI docs forMtlsConfigwere rendered and verified locally.The full
./scripts/mk-docs.shworkflow remains blocked in this environment by missing MySQL client tooling required by a transitive dependency.Closes #2938.