Conversation
Add Makefile and structs::ExtensionVersionCompatibility Refactor extensions to accept Arc<String> pg_version Resolve per-Postgres extension versions via LazyLock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the PostgreSQL extensions installer project, focusing on robust version management for extensions, improved concurrency handling, and enhanced documentation for both English and Spanish-speaking contributors and users. The installer now selects extension versions dynamically based on the PostgreSQL version, and the documentation has been expanded to include detailed contribution guidelines and project overviews in both languages.
Key changes:
Extension Version Management and Installer Logic
ExtensionVersionCompatibilitystruct insrc/structs.rsto map supported PostgreSQL major versions to compatible extension versions, along with aget_versionmethod for dynamic lookup.src/extensions/postgis.rs,src/extensions/pgmq.rs, andsrc/extensions/pgvector.rsto useExtensionVersionCompatibilityand accept the PostgreSQL version as anArc<String>, enabling dynamic and thread-safe version selection for each extension during installation. [1] [2] [3]src/extensions/mod.rsandsrc/main.rsto pass the PostgreSQL version as anArc<String>to all extension installers, improving concurrency and ensuring correct versioning in parallel tasks. [1] [2] [3]Documentation and Contributor Guidelines
CONTRIBUTING.md) and Spanish (CONTRIBUTING.es.md), including workflows, coding standards, PR checklists, and extension addition instructions. [1] [2]README.mdandREADME.es.md) with clear explanations of project purpose, included extensions, the rationale for using Rust, version management strategy, and links to the new contributor guides. [1] [2]Build and Testing Improvements
makefilewithtestandbuildtargets to streamline local Docker builds and testing.These changes make the project more maintainable, contributor-friendly, and robust in handling multiple PostgreSQL and extension versions.