fix(ruvllm): detect tied word embeddings for Llama 3.2 in candle backend#645
Open
ohdearquant wants to merge 1 commit into
Open
fix(ruvllm): detect tied word embeddings for Llama 3.2 in candle backend#645ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
Llama 3.2 1B/3B tie the output projection to the input embeddings, so the checkpoint has no separate lm_head.weight tensor. The candle backend hardcoded tie_word_embeddings: false, which fails to load these models. Detect the tie from tensor presence instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Llama 3.2 1B/3B tie the output projection to the input embeddings — the checkpoint ships no separate
lm_head.weighttensor. The candle backend hardcodedtie_word_embeddings: false, so loading a Llama 3.2 checkpoint fails on the missinglm_head.weight.Fix
Detect the tie from tensor presence instead of hardcoding:
Models that ship an explicit
lm_head.weightare unaffected (detected as untied, same as before); Llama 3.2 1B/3B now load correctly.Scope
6 lines,
candle_backend.rsonly, behind thecandlefeature. No new dependencies.Verification
cargo check -p ruvllm --features candlepasses clean (candle-transformers 0.9.2).🤖 Generated with Claude Code