perf(rls): wrap current_setting() in the generated tenant policy for per-statement evaluation#639
Open
dmitrymaranik wants to merge 2 commits into
Open
perf(rls): wrap current_setting() in the generated tenant policy for per-statement evaluation#639dmitrymaranik wants to merge 2 commits into
dmitrymaranik wants to merge 2 commits into
Conversation
…per-statement eval
…per-statement eval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruvnet/RuVector's RLS policy generator emitscurrent_setting('<tenant setting>')unwrapped in the policy predicate. Postgres re-evaluates a barecurrent_setting(...)once per row the policy scans; wrapping it in a scalar subquery —(select current_setting(...))— makes it a per-statement InitPlan the planner evaluates once and caches. It's predicate-equivalent (tenant isolation unchanged) and the documented Postgres RLS performance pattern; the benefit grows with table size.This wraps the generated call and keeps the test assertions in sync (
rls.rs,isolation.rs). I couldn't run the Rust test suite locally — if CI surfaces another assertion on the generated policy SQL, point me at it and I'll update it.Spotted with pgrls (an open-source Postgres RLS analyzer). Happy to adjust.