Skip to content

Add advisory for sfbinpack: OOB read via BitReader #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yaokunzhang wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −0
Open

Add advisory for sfbinpack: OOB read via BitReader #2859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions crates/sfbinpack/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "sfbinpack"
date = "2026-05-02"
url = "https://github.com/Disservin/binpack-rust/issues/17"
informational = "unsound"
categories = ["memory-corruption"]
keywords = ["out-of-bounds"]

[versions]
patched = []
Copy link
Copy Markdown
Member

@djc djc May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have been fixed in 0.6.2.

```

# Out-of-bounds read via `BitReader` in `CompressedTrainingDataEntryReader`

`CompressedTrainingDataEntryReader` constructs a `BitReader` from a raw
pointer without tracking length. A crafted chunk with `num_plies > 0` but no
movetext bytes triggers out-of-bounds reads via the `BitReader`, which uses
`*self.movetext.add(self.read_offset)` without bounds checks.

This can be triggered through safe public APIs —
`CompressedTrainingDataEntryReader::new()` and `.next()` — with no `unsafe`
required from the caller.