Add advisory for vku VMABuffer::set_data unsoundness#2849
Open
sisy2020 wants to merge 2 commits into
Open
Conversation
Member
|
Please obtain approval from the maintainer when submitting advisories. |
|
While I feel humbled that my personal side-project gets any attention, I don't think this advisory is warranted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an informational RustSec advisory for an unsound safe API in
vku.VMABuffer::set_dataaccepted an arbitrary offset and used it in unsafe pointer arithmetic before copying data into a mapped allocation. A safe caller could trigger an out-of-bounds write.Upstream issue: ArrowMaxGithub/vku#5
Fix commit: ArrowMaxGithub/vku@ce02c19
Patched version: 0.4.0