-
Notifications
You must be signed in to change notification settings - Fork 470
Fix incomplete affected functions for RUSTSEC-2026-0041 #2724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Marcono1234
wants to merge
1
commit into
rustsec:main
Choose a base branch
from
Marcono1234:lz4_flex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,14 @@ cvss = "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N" | |
| [affected.functions] | ||
| "lz4_flex::block::decompress_into" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::block::decompress_into_with_dict" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::block::decompress" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::block::decompress_with_dict" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::block::decompress_size_prepended" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::block::decompress_size_prepended_with_dict" = ["<= 0.11.5", "= 0.12.0"] | ||
| # Deprecated re-exports | ||
| "lz4_flex::decompress" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::decompress_into" = ["<= 0.11.5", "= 0.12.0"] | ||
| "lz4_flex::decompress_size_prepended" = ["<= 0.11.5", "= 0.12.0"] | ||
|
|
||
| [versions] | ||
| patched = [">= 0.11.6, < 0.12.0", ">= 0.12.1"] | ||
|
|
@@ -28,13 +36,12 @@ the initialized portion of the output buffer. | |
|
|
||
| Two scenarios are affected: | ||
|
|
||
| - Decompressing with the `unsafe` implementation (`safe-decode` feature flag disabled, which | ||
| is the default): can leak content of uninitialized memory as part of the decompressed result. | ||
| - Decompressing with the `unsafe` implementation (`safe-decode` feature flag disabled; flag is | ||
| enabled by default): can leak content of uninitialized memory as part of the decompressed result. | ||
|
Comment on lines
-31
to
+40
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reworded this to make it (hopefully) clearer; "which is the default" might have been ambiguous, e.g. whether it means "the flag is enabled by default" or "the flag being disabled is the default". I hope that is ok. |
||
| - Decompressing into a reused, user-supplied output buffer (also affects `safe-decode`): can | ||
| leak the previous contents of the output buffer as part of the decompressed result. | ||
|
|
||
| Only the block-based API is affected: `lz4_flex::block::decompress_into` and | ||
| `lz4_flex::block::decompress_into_with_dict`. All frame APIs are unaffected. | ||
| Only the block-based API is affected. All frame APIs are unaffected. | ||
|
|
||
| The flaw was corrected in versions 0.11.6 and 0.12.1 by properly validating offset values | ||
| during decompression. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I did not overlook something here. If possible please double-check.