fix: reject alias endpoints with path components#220
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens alias endpoint validation to reject HTTP(S) URLs that include path, query, or fragment components, ensuring aliases represent a plain service root endpoint, and adds regression tests for the rejected URL shapes.
Changes:
- Add validation to reject endpoints containing non-root paths, query strings, or fragments.
- Reuse the stricter validation for both direct alias endpoints and
RC_HOST_*env alias parsing. - Add a unit test covering path/query/fragment rejection cases.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a24fdb5 to
44b1102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspacerc alias set bad http://127.0.0.1:9000/api access secretnow exits with usage error and does not save the alias