Skip to content

Update dependencies and address clippy lints #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukehsiao wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update dependencies and address clippy lints #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01eca5
build(deps): update `atom_syndication` to v0.12
lukehsiao May 11, 2023
ef6e6e5
style: fix all `clippy` lints
lukehsiao May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ keywords = ["atom", "blog", "feed", "rss", "syndication"]
exclude = ["test-data/*"]

[dependencies]
atom_syndication = "0.11"
atom_syndication = "0.12"
rss = "2.0"
12 changes: 5 additions & 7 deletions examples/read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ fn main() {
</feed>
"#;

match atom_str.parse::<Feed>().unwrap() {
Feed::Atom(atom_feed) => println!(
if let Feed::Atom(atom_feed) = atom_str.parse::<Feed>().unwrap() {
println!(
"Atom feed first entry: {:?}",
atom_feed.entries()[0].title()
),
_ => {}
);
};

let rss_str = r#"
Expand All @@ -41,8 +40,7 @@ fn main() {
</rss>
"#;

match rss_str.parse::<Feed>().unwrap() {
Feed::RSS(rss_feed) => println!("RSS feed first entry: {:?}", rss_feed.items()[0].title()),
_ => {}
if let Feed::RSS(rss_feed) = rss_str.parse::<Feed>().unwrap() {
println!("RSS feed first entry: {:?}", rss_feed.items()[0].title());
};
}
20 changes: 10 additions & 10 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ impl FromStr for Feed {
impl ToString for Feed {
fn to_string(&self) -> String {
match self {
&Feed::Atom(ref atom_feed) => atom_feed.to_string(),
&Feed::RSS(ref rss_channel) => rss_channel.to_string(),
Feed::Atom(atom_feed) => atom_feed.to_string(),
Feed::RSS(rss_channel) => rss_channel.to_string(),
}
}
}
Expand All @@ -44,7 +44,7 @@ mod test {
let mut atom_string = String::new();
file.read_to_string(&mut atom_string).unwrap();
let feed = Feed::from_str(&atom_string).unwrap();
assert!(feed.to_string().len() > 0);
assert!(!feed.to_string().is_empty());
}

// Source: https://github.com/frewsxcv/rust-rss/blob/master/src/lib.rs
Expand All @@ -54,7 +54,7 @@ mod test {
let mut rss_string = String::new();
file.read_to_string(&mut rss_string).unwrap();
let rss = Feed::from_str(&rss_string).unwrap();
assert!(rss.to_string().len() > 0);
assert!(!rss.to_string().is_empty());
}

// Source: https://github.com/vtduncan/rust-atom/blob/master/src/lib.rs
Expand All @@ -66,11 +66,11 @@ mod test {

let entry = atom_syndication::EntryBuilder::default()
.title("My first post!")
.content(
.content(Some(
atom_syndication::ContentBuilder::default()
.value("This is my first post".to_string())
.value(Some("This is my first post".to_string()))
.build(),
)
))
.build();

let feed = atom_syndication::FeedBuilder::default()
Expand All @@ -86,9 +86,9 @@ mod test {
#[test]
fn test_rss_to_string() {
let item = rss::ItemBuilder::default()
.title("My first post!".to_string())
.link("http://myblog.com/post1".to_string())
.description("This is my first post".to_string())
.title(Some("My first post!".to_string()))
.link(Some("http://myblog.com/post1".to_string()))
.description(Some("This is my first post".to_string()))
.build();

let channel = rss::ChannelBuilder::default()
Expand Down