Clarify TODO comments in options2 exercise#2336
Open
jjstrnad wants to merge 1 commit intorust-lang:mainfrom
Open
Clarify TODO comments in options2 exercise#2336jjstrnad wants to merge 1 commit intorust-lang:mainfrom
jjstrnad wants to merge 1 commit intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1990
Summary
Clarified TODO comments in options2 exercise to indicate that the code needs to be completed rather than replaced.
Problem
The current TODO comments say "Make this an if-let statement" and "Make this a while-let statement", which implies the existing code is already a valid statement that needs to be transformed into something else. This caused confusion for many learners who expected to replace valid code with different valid code.
In reality, the code is syntactically incomplete and needs keywords added (
if letandwhile let) to become valid statements.Solution
Updated the TODO comments to explicitly state that learners need to complete the incomplete statements by adding the missing keywords and patterns.