-
Notifications
You must be signed in to change notification settings - Fork 164
Toggle status page date format between 24hr and 12hr #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments.
| timeline: BenchmarkRequestRow[]; | ||
| queueLength: number; | ||
| collectors: CollectorConfig[]; | ||
| dateFmt: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dateFmt doesn't belong here, this is data loaded from the server. But we don't need to remember it and duplicate state, it's enough to just load the data from localstorage always (see my other comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha.
I think we need it in state to trick VUE.js into re-rendering the screen. Though I could be wrong, if we do need this wizardy I'll use another Ref<...> type as like you say I'm mixing some ui thing with something from the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c943210 I tried and it didn't work. So I split it out with a comment as to why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it worked for me when I tried it locally before. The component should re-render when the event is triggered, I think. I'll check.
A little checkbox button allowing changing the date format between 24hr and 12hr;
24hr
12hr
Closes #2347