Skip to content

Conversation

@Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Dec 16, 2025

A little checkbox button allowing changing the date format between 24hr and 12hr;

24hr

24hr format

12hr

12hr format

Closes #2347

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments.

timeline: BenchmarkRequestRow[];
queueLength: number;
collectors: CollectorConfig[];
dateFmt: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dateFmt doesn't belong here, this is data loaded from the server. But we don't need to remember it and duplicate state, it's enough to just load the data from localstorage always (see my other comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha.

I think we need it in state to trick VUE.js into re-rendering the screen. Though I could be wrong, if we do need this wizardy I'll use another Ref<...> type as like you say I'm mixing some ui thing with something from the server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c943210 I tried and it didn't work. So I split it out with a comment as to why

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it worked for me when I tried it locally before. The component should re-render when the event is triggered, I think. I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow switching time format on the status page

2 participants