Rollup of 6 pull requests#158043
Open
JonathanBrouwer wants to merge 15 commits into
Open
Conversation
Document the built-in `must_use` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `keyword_docs.rs` pattern.
To get a `LintVec` for a lint pass we sometimes use `get_lints` and sometimes use `lint_vec`. It would be nice to only have one, but doing that is tricky. In the meantime, this commit makes the naming more consistent. - By always using the name `get_lints` for the methods that take `self`. - By always using the name `lint_vec` for the methods that have no parameters.
These are both types that impl `LintPass` but in a degenerate way: only the `lint_vec` method is ever used. This commit changes them to just be a `lint_vec` function in an appropriately-named module. The commit also removes the use of `HardwiredLints` in `late_lint_crate`, which had no effect because all the `HardwiredLints::check_*` methods were no-ops.
- Document which pass each lint belongs to. - Make the lint ordering consistent. - Add (commented out) `SYMBOL_INTERN_STRING_LITERAL`, which was missing, with an explanation of why it's disabled.
And fix a few cases it catches.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
…fonthey,saethlin make more slice mutable ref getters rustc_no_writable This makes https://rust.godbolt.org/z/TreEYqfW8 work. Cc @quiode @JoJoDeveloping
…ross Document that destructors in running threads are not run on program exit It's my understanding that, when a Rust program's main thread terminates and thereby causes any still-running threads to be shut down, destructors are not run for the shut-down threads; however, the documentation doesn't seem to come out and say that explicitly anywhere. This PR therefore adds an explicit statement about this to the `std::thread` docs. If I am mistaken and destructors *are* run, that's worth documenting explicitly, too.
… r=GuillaumeGomez,ehuss Add documentation for the `must_use` attribute Document the built-in `must_use` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `keyword_docs.rs` pattern. Part of rust-lang#157604. r? @GuillaumeGomez Tested with `./x test library/std --doc`.
…s-SoftLints, r=Urgau Simplify `HardwiredLints` and `SoftLints` Details in individual commits. r? @Urgau
…cies, r=marcoieni Pin dependencies This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) | action | pinDigest | → `93cb6ef` | | [actions/download-artifact](https://redirect.github.com/actions/download-artifact) | action | pinDigest | → `3e5f45b` | | [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | pinDigest | → `043fb46` | --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rust-lang/rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTkuMCIsInVwZGF0ZWRJblZlciI6IjQzLjIxOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
…iteral-rustdoc, r=Urgau Enable `symbol_intern_string_literal` lint for rustdoc Details in individual commits. r? @Urgau
rustbot
added
A-CI
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit ed85b5b with merge 9e5ee08… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/27707333103 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
|
⌛ Testing commit ed85b5b with merge c1b22f4... Workflow: https://github.com/rust-lang/rust/actions/runs/27709290117 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…uwer Rollup of 6 pull requests Successful merges: - #157816 (make more slice mutable ref getters rustc_no_writable) - #156788 (Document that destructors in running threads are not run on program exit) - #157957 (Add documentation for the `must_use` attribute) - #158006 (Simplify `HardwiredLints` and `SoftLints`) - #158007 (Pin dependencies) - #158025 (Enable `symbol_intern_string_literal` lint for rustdoc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
must_useattribute #157957 (Add documentation for themust_useattribute)HardwiredLintsandSoftLints#158006 (SimplifyHardwiredLintsandSoftLints)symbol_intern_string_literallint for rustdoc #158025 (Enablesymbol_intern_string_literallint for rustdoc)r? @ghost
Create a similar rollup