Reject impl const Trait since the right syntax is const impl Trait now#158009
Open
oli-obk wants to merge 1 commit into
Open
Reject impl const Trait since the right syntax is const impl Trait now#158009oli-obk wants to merge 1 commit into
impl const Trait since the right syntax is const impl Trait now#158009oli-obk wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @lcnr The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease
cc @rust-lang/rustfmt
cc @Amanieu, @folkertdev, @sayantn |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
4ee676c to
b677ee5
Compare
This comment has been minimized.
This comment has been minimized.
b677ee5 to
a88521a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also let some smaller rustfmting of ui tests through, as rustfmt immediately formats
impl const Traittoconst impl Trait. This is also the reason I expect that this change will break very little nightly users, so we don't even need to add some helpful diagnostic.r? @fee1-dead