Rename diagnostic::on_unmatch_args to diagnostic::on_unmatched_args#157887
Merged
Conversation
Collaborator
|
Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs |
rustbot
added
A-attributes
fmease
commented
Jun 14, 2026
| /// Allows deriving traits as per `SmartPointer` specification | ||
| (removed, derive_smart_pointer, "1.84.0", Some(123430), Some("replaced by `CoercePointee`"), 131284), | ||
| /// Allows macros to customize macro argument matcher diagnostics. | ||
| (removed, diagnostic_on_unmatch_args, "CURRENT_RUSTC_VERSION", Some(155642), Some("renamed to `diagnostic_on_unmatched_args`"), 157887), |
Member
Author
There was a problem hiding this comment.
It's a bit unfortunate that we have to add a tombstone two months after the feature's introduction but oh well.
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
rn-to-on-unmatched-args
branch
from
f381afe to
f1acff6
Compare
fmease
changed the title
diagnostics::on_unmatch_args to diagnostics::on_unmatched_argsdiagnostic::on_unmatch_args to diagnostic::on_unmatched_args
fmease
force-pushed
the
rn-to-on-unmatched-args
branch
from
f1acff6 to
69a17b1
Compare
mejrs
approved these changes
Jun 14, 2026
Contributor
There was a problem hiding this comment.
Thanks! I do like this better. Also the attribute documentation efforts are much appreciated 🙂
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 14, 2026
…uwer Rollup of 5 pull requests Successful merges: - #157677 (Slightly improve diagnostic impl+output for uncovered type parameters) - #157715 (Stop using a fn pointer to normalize_fn_sig inside TypeErrCtxt) - #157884 (Rename `errors.rs` file to `diagnostics.rs` (9/N)) - #157887 (Rename `diagnostic::on_unmatch_args` to `diagnostic::on_unmatched_args`) - #157888 (Avoid `&raw` call recovery inside nested delimiters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renders the name of the attribute and the feature grammatical. #154794 (comment).
r? mejrs