mips: set llvm_args -mno-check-zero-division for all mips targets#157873
Open
xry111 wants to merge 1 commit into
Open
mips: set llvm_args -mno-check-zero-division for all mips targets#157873xry111 wants to merge 1 commit into
xry111 wants to merge 1 commit into
Conversation
In rust interger divide by zero is defined to panic, thus the inserted conditional trap should never trigger as the program should have panicked if the divisor is zero. So disable the insertion of the redundant conditional trap.
Collaborator
|
These commits modify compiler targets. |
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Specifically https://doc.rust-lang.org/reference/expressions/operator-expr.html#r-expr.arith-logic.behavior documents:
Adding the flag does in fact have an effect on codegen (I'd have assumed that LLVM would be able to spot this, but I guess not) https://rust.godbolt.org/z/evacM46bM It's probably a good idea to capture that in an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust interger divide by zero is defined to panic, thus the inserted conditional trap should never trigger as the program should have panicked if the divisor is zero.
So disable the insertion of the redundant conditional trap.