Do not increase depth when evaluating nested goals of NormalizesTo#157718
Open
ShoyuVanilla wants to merge 1 commit into
Open
Do not increase depth when evaluating nested goals of NormalizesTo#157718ShoyuVanilla wants to merge 1 commit into
NormalizesTo#157718ShoyuVanilla wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Jun 16, 2026
Comment on lines
+641
to
+645
| parent.required_depth = | ||
| parent.required_depth.max(match parent.increase_depth_for_nested { | ||
| IncreaseDepthForNested::Yes => required_depth_for_nested + 1, | ||
| IncreaseDepthForNested::No => required_depth_for_nested, | ||
| }); |
Contributor
There was a problem hiding this comment.
I've been thinking about about this as this feels brittle. Instead of required_depth, could we change the search graph to track the "min_reached_available_depth" and then required depth is computed as "available_depth - min_reached_available_depth"
that way the way depth is actually tracked doesn't matter anymore
Member
Author
There was a problem hiding this comment.
Sounds good to me. I'll try that way 👍
ShoyuVanilla
force-pushed
the
nested-normalizes-to-without-depth-increase
branch
from
e59d7fa to
dc07fda
Compare
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #156619 (comment)
Only the last commit is relevant since this is based on #156619r? lcnr