Slightly improve diagnostic impl+output for uncovered type parameters#157677
Merged
Conversation
Collaborator
|
This PR modifies |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment was marked as outdated.
This comment was marked as outdated.
fmease
commented
Jun 9, 2026
fmease
force-pushed
the
orphanck-improv-diag
branch
from
8e9e9c8 to
4726555
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
r=me after rebase |
fmease
force-pushed
the
orphanck-improv-diag
branch
from
4726555 to
2fda233
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Moreover, don't add the error code to the lint warning(!). While helpful, it's quite unconventional.
The diagnostic is generally very noisy.
This commit tries to make it slightly less cluttered and more legible by
1. stopping to reuse the lengthy primary message as the primary label.
This duplication didn't increase the information content and only
turned the diagnostic into a letter and symbol soup.
Instead, we now pick a succinct label ("uncovered type parameter")
that immediately(!) signals to the users in red what is wrong with
the highlighted type parameter.
2. breaking some information-dense notes into multiple lines.
Finally, this rephrases the slightly awkward and confusing
"type parameter […] must be used as a type parameter for […] type" to
"type parameter […] must be used as an argument to […] type".
Member
Author
|
@bors r=jackh726 rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 14, 2026
…kh726 Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR rust-lang#135910. No behavioral changes. See individual commit messages for details.
Contributor
|
⌛ Testing commit 2fda233 with merge 4fa96d0... Workflow: https://github.com/rust-lang/rust/actions/runs/27503272216 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 14, 2026
Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR #135910. No behavioral changes. See individual commit messages for details.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 14, 2026
…kh726 Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR rust-lang#135910. No behavioral changes. See individual commit messages for details.
Contributor
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #157893. |
Contributor
|
⌛ Testing commit 2fda233 with merge 735ac6c... Workflow: https://github.com/rust-lang/rust/actions/runs/27505463383 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 14, 2026
Slightly improve diagnostic impl+output for uncovered type parameters Split out of PR #135910. No behavioral changes. See individual commit messages for details.
Contributor
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #157894. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 14, 2026
…uwer Rollup of 5 pull requests Successful merges: - #157677 (Slightly improve diagnostic impl+output for uncovered type parameters) - #157715 (Stop using a fn pointer to normalize_fn_sig inside TypeErrCtxt) - #157884 (Rename `errors.rs` file to `diagnostics.rs` (9/N)) - #157887 (Rename `diagnostic::on_unmatch_args` to `diagnostic::on_unmatched_args`) - #157888 (Avoid `&raw` call recovery inside nested delimiters)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of PR #135910. No behavioral changes.
See individual commit messages for details.