Reject arguments to local_inner_macros for #[macro_export]#155091
Closed
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Closed
Reject arguments to local_inner_macros for #[macro_export]#155091JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
local_inner_macros for #[macro_export]#155091JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
Conversation
JonathanBrouwer
added
S-blocked
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
Reject arguments to `local_inner_macros` for `#[macro_export]`
Contributor
|
Alright, this falls under the policy of notify T-lang + crater run, but no FCP right? |
Contributor
JonathanBrouwer
removed
the
needs-rfc
Contributor
Author
Right, I think that makes sense, assuming crater finds nothing @craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
Contributor
Author
|
Closed in favour of #155193 |
Collaborator
|
🗑️ Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154977
This is a breaking change, as it adds new cases to a deny-by-default lint.
r? @jdonszelmann