Use special DefIds for aliases#155025
Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Like we do for other things for better experience in rust-analyzer. It's possible now that the `AliasTyKind` contains the DefId. It does require a few unwraps since `AliasTermKind` still does not contain the DefId and some things only include a DefId with no kind, but IMO it's still better.
jieyouxu
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like we do for other things for better experience in rust-analyzer.
It's possible now that the
AliasTyKindcontains the DefId. It does require a few unwraps sinceAliasTermKindstill does not contain the DefId and some things only include a DefId with no kind, but IMO it's still better.r? types