Suggest the [const] Destruct bound for type parameters in const functions when missing#155013
Open
jakubadamw wants to merge 2 commits intorust-lang:mainfrom
Open
Suggest the [const] Destruct bound for type parameters in const functions when missing#155013jakubadamw wants to merge 2 commits intorust-lang:mainfrom
[const] Destruct bound for type parameters in const functions when missing#155013jakubadamw wants to merge 2 commits intorust-lang:mainfrom
Conversation
…ctions When a const function drops a value whose type is a type parameter, suggest adding a `[const] Destruct` bound so the destructor can be evaluated at compile-time.
Collaborator
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
[const] Destruct bound for type parameters in const functions[const] Destruct bound for type parameters in const functions when missing
Member
|
thanks for the contribution, but this is experimental syntax which means syntax may change in future, so I think it should be held until stabilization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a const function drops a value whose type is a type parameter without a
[const] Destructbound, suggest adding it so that the destructor can be evaluated at compile-time.Closes #103270.
Example:
Before:
After:
No new tests as the existing ones had their results updated with the new suggestion.