Clarify ASCII whitespace docs in u8::is_ascii_whitespace#155012
Open
Brace1000 wants to merge 1 commit intorust-lang:mainfrom
Open
Clarify ASCII whitespace docs in u8::is_ascii_whitespace#155012Brace1000 wants to merge 1 commit intorust-lang:mainfrom
Brace1000 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
14 tasks
The standard library uses the WhatWG Infra Standard definition of ASCII whitespace, which does not include vertical tab (U+000B). The Rust language parser uses Unicode Pattern_White_Space, which does include it.
Brace1000
force-pushed
the
fix-ascii-whitespace-docs
branch
from
b000558 to
ea96c6c
Compare
Contributor
|
@Brace1000 sorry, looks like this is a duplicate of PR #154765 That's my mistake, let's find you another Outreachy task instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the docs for u8::is_ascii_whitespace to make it clear
that the standard library uses WhatWG rules for ASCII whitespace,
so vertical tab (U+000B) isn’t included. Also note that the Rust
parser uses a different definition.
Ref: #154765