add miri strong mode for tree borrows#154948
Closed
quiode wants to merge 2 commits intorust-lang:mainfrom
Closed
Conversation
This was referenced Apr 7, 2026
Author
|
r? @RalfJung |
Collaborator
|
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Thanks! Could you make a Miri PR that doesn't depend on #154946? It should be possible to have a flag like |
Contributor
|
☔ The latest upstream changes (presumably #154958) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #154946. It tries to address rust-lang/unsafe-code-guidelines#584 (comment). It is part of a bachelor thesis supervised by @JoJoDeveloping and @RalfJung, for more information, see: Project_Description.pdf.
In Tree Borrows, Miri now checks for spurious writes on function entry, if
no_writableis not set. This means that all mutable references on function entry have to be writable, violating this is Undefined Behaviour. The compiler can then make use of this in #154949.