Refactor: simplify report_selection_error#154939
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Apr 14, 2026
Merged
Refactor: simplify report_selection_error#154939rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
davidtwco
approved these changes
Apr 13, 2026
chenyukang
force-pushed
the
yukang-refactor-fn-pointer-cast-suggestion
branch
from
c400d43 to
41b357e
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-refactor-fn-pointer-cast-suggestion
branch
from
41b357e to
270cc62
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=davidtwco |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
Rollup of 5 pull requests Successful merges: - #149357 (Implement `-Z allow-partial-mitigations` (RFC 3855)) - #154939 (Refactor: simplify report_selection_error) - #152688 (Trait aliases: Also imply default trait bounds on type params other than `Self`) - #154352 (rustdoc: dep-info for standalone markdown inputs) - #155195 (tidy: handle `#[cfg_attr(bootstrap, doc = "...")]` in `compiler/` comments)
rust-timer
added a commit
that referenced
this pull request
Apr 14, 2026
Rollup merge of #154939 - chenyukang:yukang-refactor-fn-pointer-cast-suggestion, r=davidtwco Refactor: simplify report_selection_error Split out `suggest_cast_to_fn_pointer` for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out
suggest_cast_to_fn_pointerfor better readability.