Skip to content

Emit fatal on defaults for generic params in binders if with nested defs#154642

Open
mu001999 wants to merge 1 commit intorust-lang:mainfrom
mu001999-contrib:fix/123629
Open

Emit fatal on defaults for generic params in binders if with nested defs#154642
mu001999 wants to merge 1 commit intorust-lang:mainfrom
mu001999-contrib:fix/123629

Conversation

@mu001999
Copy link
Copy Markdown
Contributor

@mu001999 mu001999 commented Mar 31, 2026

Fixes #123629

Such defaults won't be lowered to hir, but the nested items would be. Then ICE will happen when later error handling walks HIR parents of inner items.

Similar to #154595

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 31, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 31, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: ast_lowering, compiler
  • ast_lowering, compiler expanded to 69 candidates
  • Random selection from 13 candidates

@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented Apr 2, 2026

r? BoxyUwU
given the overlap between the two PRs

@rustbot rustbot assigned BoxyUwU and unassigned jackh726 Apr 2, 2026
@rust-bors

This comment has been minimized.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 10, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: No HirID for DefId(...) with feature generic_assert

4 participants