report the `varargs_without_pattern` lint in deps by folkertdev · Pull Request #154599 · rust-lang/rust

folkertdev · 2026-03-30T16:18:43Z

tracking issue: #44930

After discussion in rust-lang/reference#2177 (comment).

Based on #143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment).

Hence we may as well report this loudly.

r? @ghost

joshtriplett · 2026-04-01T15:08:34Z

When we move FCWs to warn in deps, we typically change them to deny-by-default as well. Could you please make that change too?

joshtriplett · 2026-04-01T15:08:43Z

@rfcbot merge lang

rust-rfcbot · 2026-04-01T15:08:52Z

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

traviscross · 2026-04-01T15:09:03Z

@rfcbot reviewed

(Inclusive of changing this to deny-by-default.)

rust-rfcbot · 2026-04-01T15:09:51Z

🔔 This is now entering its final comment period, as per the review above. 🔔

folkertdev · 2026-04-01T18:59:27Z

I'm confused by that failure, there are 3 failing tests which is weird given the diff

failures:
    compiler/rustc_lint_defs/src/builtin.rs - builtin::FORBIDDEN_LINT_GROUPS (line 166)
    compiler/rustc_lint_defs/src/builtin.rs - builtin::VARARGS_WITHOUT_PATTERN (line 5559)
    compiler/rustc_lint_defs/src/builtin.rs - builtin::WARNINGS (line 1068)

Also locally the doc tests (which I believe is what these are) work fine when I run ./x test compiler/rustc_lint_defs --doc.

ehuss · 2026-04-01T22:32:18Z

Also locally the doc tests (which I believe is what these are) work fine when I run ./x test compiler/rustc_lint_defs --doc.

You need --stage 2 to reproduce.

The problem is a bit complicated. What happens is that rustdoc combines doctests into a single crate. When it fails to build that crate, it then falls back to the "unmerged" mode. With varargs_without_pattern being changed to Deny, the merged doctests no longer compile because fn foo(...) is now an error by default.

The example needs to be marked with ,compile_fail. I would also double-check that everything continues to work when testing with both stage1 and stage2, but I think that should be sufficient.

…=<try> report the `varargs_without_pattern` lint in deps try-job: x86_64-gnu-llvm-22-3

rust-bors · 2026-04-11T17:33:13Z

☀️ Try build successful (CI)
Build commit: 6fff4c8 (6fff4c80932abe41842174589cac6a3aafefbce3, parent: 5f36a7f8072e835d73d9e1f7ab8a2134ac7352dc)

folkertdev · 2026-04-11T17:35:14Z

given that you've been looking at this already

r? ehuss

ehuss · 2026-04-13T15:33:51Z

given that you've been looking at this already

I am not on the compiler team, and would prefer to assign to someone else.

rustbot · 2026-04-13T15:43:52Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev · 2026-04-13T15:44:01Z

Fair enough

r? compiler

@bors try jobs=x86_64-gnu-llvm-22-3

…=<try> report the `varargs_without_pattern` lint in deps try-job: x86_64-gnu-llvm-22-3

rust-bors · 2026-04-13T17:46:18Z

☀️ Try build successful (CI)
Build commit: 42f6f47 (42f6f477d9c331e3f8098ad33221b9f17c377866, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

mati865

@bors r+

View changes since this review

rust-bors · 2026-04-15T14:41:24Z

📌 Commit 7c4cf96 has been approved by mati865

It is now in the queue for this repository.

@ghost

…-in-deps, r=mati865 report the `varargs_without_pattern` lint in deps tracking issue: rust-lang#44930 After discussion in rust-lang/reference#2177 (comment). Based on rust-lang#143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment). Hence we may as well report this loudly. r? @ghost

Rollup of 6 pull requests Successful merges: - #147811 (naked functions: respect `function-sections`) - #154599 (report the `varargs_without_pattern` lint in deps) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes)

@ghost

…-in-deps, r=mati865 report the `varargs_without_pattern` lint in deps tracking issue: rust-lang#44930 After discussion in rust-lang/reference#2177 (comment). Based on rust-lang#143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment). Hence we may as well report this loudly. r? @ghost

Rollup of 18 pull requests Successful merges: - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #154970 (rustdoc: preserve `doc(cfg)` on locally re-exported type aliases) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

Rollup of 18 pull requests Successful merges: - #154451 (Require that a `<_ as Try>::Residual` implement the `Residual` trait) - #154595 (Emit fatal on invalid const args with nested defs) - #154599 (report the `varargs_without_pattern` lint in deps) - #154699 (`core::unicode`: Replace `Cased` table with `Lt`) - #155353 (resolve: Remove `inaccessible_ctor_reexport` resolver field) - #155357 (Add `--remap-path-scope` as unstable in rustdoc) - #150649 (clippy fix: non_canonical_clone_impl) - #154604 (abort in core) - #154616 (Add `--quiet` flag to x.py and bootstrap to suppress output) - #155215 (Clean up `AttributeLintKind` and refactor diagnostic attribute linting) - #155228 (Check diagnostic output in incremental `cpass` and `rpass` revisions) - #155266 (Adjust release notes for post-merge feedback) - #155326 (Disallow ZST allocations with `TypedArena`.) - #155334 (docs: Use `0b1` instead of `NonZero::MIN` in `NonZero::bit_width` doctests) - #155340 (Handle nonnull pattern types in size skeleton) - #155347 (Add push_mut and new Layout methods to release notes) - #155356 (remove calls to AliasTyKind::def_id) - #155364 (Reduce diagnostic type visibilities.)

@ghost

Rollup merge of #154599 - folkertdev:varargs-without-pattern-in-deps, r=mati865 report the `varargs_without_pattern` lint in deps tracking issue: #44930 After discussion in rust-lang/reference#2177 (comment). Based on #143619 (comment) there was only one actual impacted crate https://crates.io/crates/binrw. The issue was fixed in jam1garner/binrw#342, and has since been released jam1garner/binrw#342 (comment). Hence we may as well report this loudly. r? @ghost

folkertdev added F-c_variadic `#![feature(c_variadic)]` I-lang-nominated Nominated for discussion during a lang team meeting. labels Mar 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2026

folkertdev mentioned this pull request Mar 30, 2026

add c-variadic function definitions rust-lang/reference#2177

Open

This comment has been minimized.

Sign in to view

folkertdev force-pushed the varargs-without-pattern-in-deps branch from 1ed0d34 to b54ad89 Compare March 30, 2026 18:27

This comment has been minimized.

Sign in to view

folkertdev force-pushed the varargs-without-pattern-in-deps branch from b54ad89 to 5cdad1e Compare March 30, 2026 20:07

This comment has been minimized.

Sign in to view

folkertdev force-pushed the varargs-without-pattern-in-deps branch from 5cdad1e to fbe90e6 Compare March 30, 2026 21:37

traviscross added P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team labels Apr 1, 2026

traviscross added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Apr 1, 2026

rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 1, 2026

rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 1, 2026

folkertdev force-pushed the varargs-without-pattern-in-deps branch from fbe90e6 to 923279e Compare April 1, 2026 15:20

This comment has been minimized.

Sign in to view

folkertdev force-pushed the varargs-without-pattern-in-deps branch from 923279e to e2d01c6 Compare April 1, 2026 23:06

rust-bors bot pushed a commit that referenced this pull request Apr 11, 2026

Auto merge of #154599 - folkertdev:varargs-without-pattern-in-deps, r…

6fff4c8

…=<try> report the `varargs_without_pattern` lint in deps try-job: x86_64-gnu-llvm-22-3

rustbot assigned ehuss Apr 11, 2026

ehuss reviewed Apr 13, 2026

View reviewed changes

Comment thread compiler/rustc_lint_defs/src/builtin.rs Outdated

report the varargs_without_pattern lint in deps

7c4cf96

folkertdev force-pushed the varargs-without-pattern-in-deps branch from baec033 to 7c4cf96 Compare April 13, 2026 15:43

rustbot assigned mati865 and unassigned ehuss Apr 13, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 13, 2026

Auto merge of #154599 - folkertdev:varargs-without-pattern-in-deps, r…

42f6f47

…=<try> report the `varargs_without_pattern` lint in deps try-job: x86_64-gnu-llvm-22-3

mati865 approved these changes Apr 15, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2026

matthiaskrgr mentioned this pull request Apr 15, 2026

Rollup of 6 pull requests #155350

Closed

jhpratt mentioned this pull request Apr 16, 2026

Rollup of 18 pull requests #155373

Closed

jhpratt mentioned this pull request Apr 16, 2026

Rollup of 18 pull requests #155380

Merged

rust-bors bot merged commit 0238243 into rust-lang:main Apr 16, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone Apr 16, 2026

Uh oh!

Conversation

folkertdev commented Mar 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshtriplett commented Apr 1, 2026

Uh oh!

joshtriplett commented Apr 1, 2026

Uh oh!

rust-rfcbot commented Apr 1, 2026 • edited by nikomatsakis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

traviscross commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-rfcbot commented Apr 1, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

folkertdev commented Apr 1, 2026

Uh oh!

ehuss commented Apr 1, 2026

Uh oh!

rust-bors bot commented Apr 11, 2026

Uh oh!

folkertdev commented Apr 11, 2026

Uh oh!

Uh oh!

ehuss commented Apr 13, 2026

Uh oh!

rustbot commented Apr 13, 2026

Uh oh!

folkertdev commented Apr 13, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 13, 2026

Uh oh!

mati865 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

folkertdev commented Mar 30, 2026 •

edited by rustbot

Loading

rust-rfcbot commented Apr 1, 2026 •

edited by nikomatsakis

Loading

traviscross commented Apr 1, 2026 •

edited

Loading

mati865 left a comment •

edited by rustbot

Loading