Implement EII for statics by JonathanBrouwer · Pull Request #154193 · rust-lang/rust

JonathanBrouwer · 2026-03-22T00:01:27Z

This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations.

This does not implement defaults for static EIIs yet, I will do that in a followup PR

JonathanBrouwer

r? @jdonszelmann

This code touches quite a few areas of the compiler I'm not super familiar yet with, so please review carefully whether I'm doing any stupid things :3

View changes since this review

rustbot · 2026-03-26T15:51:18Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-03-26T15:51:33Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

bjorn3 · 2026-03-30T15:41:30Z

The fact that eii_impls is a list seems to imply that a single item can define multiple EIIs at the same time. Wouldn't that result in multiple statics aliasing each other with this PR? Especially with static mut that would be rather dangerous. But even without, I'm not sure that is not UB.

JonathanBrouwer · 2026-04-12T17:26:25Z

I don't have time to review today, but if you believe you have resolved my previous review comments, I don't have any objections to merging this without me reviewing it again.

I have resolved your previous review comments by disallowing EII on static muts and by disallowing multiple eii impls on 1 static, and Jana reviewed this.

If you only defining a single EII per static, then tcx.symbol_name() on the impl can return the symbol name of the declaration.

I have however not implemented this suggestion, because the implementation is significantly more complex especially around default impls, and I don't understand why the current implementation would be problematic.

bjorn3 · 2026-04-12T17:49:20Z

I have resolved your previous review comments by disallowing EII on static muts and by disallowing multiple eii impls on 1 static, and Jana reviewed this.

👍

I have however not implemented this suggestion, because the implementation is significantly more complex especially around default impls, and I don't understand why the current implementation would be problematic.

That is fine to leave for later. For functions I believe the same is done as this PR does for statics. If statics without defaults get changed in the way I suggested, functions without defaults should be changed too.

JonathanBrouwer · 2026-04-12T17:51:59Z

Then
@bors r=jdonszelmann rollup
Thanks for the review to both of you <3

rust-bors · 2026-04-12T17:52:03Z

📋 This PR cannot be approved because it currently has the following label: S-blocked.

JonathanBrouwer · 2026-04-12T17:53:26Z

@bors r=jdonszelmann

rust-bors · 2026-04-12T17:53:29Z

📌 Commit 106b16c has been approved by jdonszelmann

It is now in the queue for this repository.

…=jdonszelmann Implement EII for statics This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations. This does not implement defaults for static EIIs yet, I will do that in a followup PR

…uwer Rollup of 4 pull requests Successful merges: - #155162 (relnotes for 1.95) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…=jdonszelmann Implement EII for statics This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations. This does not implement defaults for static EIIs yet, I will do that in a followup PR

…uwer Rollup of 6 pull requests Successful merges: - #155162 (relnotes for 1.95) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #154624 (Make `DerefPure` dyn-incompatible) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…=jdonszelmann Implement EII for statics This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations. This does not implement defaults for static EIIs yet, I will do that in a followup PR

…uwer Rollup of 13 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

…=jdonszelmann Implement EII for statics This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations. This does not implement defaults for static EIIs yet, I will do that in a followup PR

…uwer Rollup of 19 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #153604 (Fix thread::available_parallelism on WASI targets with threads) - #154193 (Implement EII for statics) - #154389 (Add more robust handling of nested query cycles) - #154435 (resolve: Some import resolution cleanups) - #155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - #155243 (cg_ssa: transmute between scalable vectors) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155055 (UI automation) - #155062 (Move tests from `tests/ui/issues/` to appropriate directories) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - #155194 (Fix manpage version replacement and use verbose version)

Rollup merge of #154193 - JonathanBrouwer:external-static, r=jdonszelmann Implement EII for statics This PR implements EII for statics. I've tried to mirror the implementation for functions in a few places, this causes some duplicate code but I'm also not really sure whether there's a clean way to merge the implementations. This does not implement defaults for static EIIs yet, I will do that in a followup PR

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#155162 (relnotes for 1.95) - rust-lang/rust#140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - rust-lang/rust#153604 (Fix thread::available_parallelism on WASI targets with threads) - rust-lang/rust#154193 (Implement EII for statics) - rust-lang/rust#154389 (Add more robust handling of nested query cycles) - rust-lang/rust#154435 (resolve: Some import resolution cleanups) - rust-lang/rust#155236 (Normalize individual predicate of `InstantiatedPredicates` inside `predicates_for_generics`) - rust-lang/rust#155243 (cg_ssa: transmute between scalable vectors) - rust-lang/rust#153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - rust-lang/rust#154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - rust-lang/rust#154624 (Make `DerefPure` dyn-incompatible) - rust-lang/rust#154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - rust-lang/rust#154944 (Small refactor of `arena_cache` query values) - rust-lang/rust#155055 (UI automation) - rust-lang/rust#155062 (Move tests from `tests/ui/issues/` to appropriate directories) - rust-lang/rust#155131 (Stabilize feature `uint_bit_width`) - rust-lang/rust#155147 (Stabilize feature `int_lowest_highest_one`) - rust-lang/rust#155174 (Improve emission of `UnknownDiagnosticAttribute` lint) - rust-lang/rust#155194 (Fix manpage version replacement and use verbose version)

JonathanBrouwer added the F-extern_item_impls `#![feature(extern_item_impls)]` label Mar 22, 2026

JonathanBrouwer force-pushed the external-static branch from e3f6d77 to 30c073d Compare March 22, 2026 00:02

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the external-static branch from 30c073d to dd4e148 Compare March 22, 2026 00:12

rustbot added the T-clippy Relevant to the Clippy team. label Mar 22, 2026

JonathanBrouwer force-pushed the external-static branch 5 times, most recently from c7aa3cf to d9d3b13 Compare March 26, 2026 15:48

JonathanBrouwer commented Mar 26, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/check/compare_eii.rs

JonathanBrouwer commented Mar 26, 2026

View reviewed changes

rustbot assigned jdonszelmann Mar 26, 2026

JonathanBrouwer changed the title ~~[VERY WIP] Implement EII for statics~~ Implement EII for statics Mar 26, 2026

JonathanBrouwer marked this pull request as ready for review March 26, 2026 15:51

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 26, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the external-static branch from d9d3b13 to 7b3a361 Compare March 26, 2026 16:01

JonathanBrouwer commented Mar 27, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/check/compare_eii.rs Outdated

JonathanBrouwer force-pushed the external-static branch from 7b3a361 to 2cb2f25 Compare March 27, 2026 21:21

jdonszelmann reviewed Mar 30, 2026

View reviewed changes

Comment thread compiler/rustc_codegen_llvm/src/mono_item.rs Outdated

jdonszelmann reviewed Mar 30, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/check/compare_eii.rs Outdated

JonathanBrouwer removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Apr 12, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2026

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 3 pull requests #155205

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 3 pull requests #155208

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 4 pull requests #155212

Closed

JonathanBrouwer mentioned this pull request Apr 12, 2026

Rollup of 6 pull requests #155214

Closed

JonathanBrouwer mentioned this pull request Apr 13, 2026

Rollup of 13 pull requests #155225

Closed

This was referenced Apr 13, 2026

Rollup of 20 pull requests #155245

Closed

Rollup of 19 pull requests #155253

Merged

rust-bors bot merged commit d2fa85c into rust-lang:main Apr 13, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone Apr 13, 2026

Uh oh!

Conversation

JonathanBrouwer commented Mar 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Mar 26, 2026

Uh oh!

rustbot commented Mar 26, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

bjorn3 commented Mar 30, 2026

Uh oh!

JonathanBrouwer commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjorn3 commented Apr 12, 2026

Uh oh!

JonathanBrouwer commented Apr 12, 2026

Uh oh!

rust-bors bot commented Apr 12, 2026

Uh oh!

JonathanBrouwer commented Apr 12, 2026

Uh oh!

rust-bors bot commented Apr 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JonathanBrouwer commented Mar 22, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer commented Apr 12, 2026 •

edited

Loading