delegation: Track more precise spans for glob delegations by petrochenkov · Pull Request #154049 · rust-lang/rust

petrochenkov · 2026-03-18T16:34:05Z

The last commit also fixes a macro hygiene issue with self in delegations found in #154002.

rustbot · 2026-03-18T16:34:10Z

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

rustbot · 2026-03-18T16:34:13Z

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 15 candidates

petrochenkov · 2026-04-07T17:33:10Z

ping @jackh726 it's been 3 weeks

tests/ui/delegation/impl-reuse-self-hygiene.rs

jackh726 · 2026-04-12T18:08:45Z

@bors r+

rust-bors · 2026-04-12T18:08:49Z

📌 Commit 66cf18e has been approved by jackh726

It is now in the queue for this repository.

delegation: Track more precise spans for glob delegations The last commit also fixes a macro hygiene issue with `self` in delegations found in rust-lang#154002.

JonathanBrouwer · 2026-04-12T19:02:27Z

@bors r-
#155205 (comment)

rust-bors · 2026-04-12T19:02:34Z

This pull request was unapproved.

This PR was contained in a rollup (#155205), which was unapproved.

petrochenkov · 2026-04-12T21:13:43Z

@bors r=jackh726

rust-bors · 2026-04-12T21:13:47Z

📌 Commit a9c2819 has been approved by jackh726

It is now in the queue for this repository.

…uwer Rollup of 6 pull requests Successful merges: - #155162 (relnotes for 1.95) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #154624 (Make `DerefPure` dyn-incompatible) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

delegation: Track more precise spans for glob delegations The last commit also fixes a macro hygiene issue with `self` in delegations found in rust-lang#154002.

…uwer Rollup of 13 pull requests Successful merges: - #155162 (relnotes for 1.95) - #140763 (Change codegen of LLVM intrinsics to be name-based, and add llvm linkage support for `bf16(xN)` and `i1xN`) - #154049 (delegation: Track more precise spans for glob delegations) - #154193 (Implement EII for statics) - #154435 (resolve: Some import resolution cleanups) - #153941 (tests/debuginfo/basic-stepping.rs: Explain why all lines are not steppable) - #154587 (Add --verbose-run-make-subprocess-output flag to suppress verbose run-make output for passing tests) - #154624 (Make `DerefPure` dyn-incompatible) - #154929 (Add `const Default` impls for `LazyCell` and `LazyLock`) - #154944 (Small refactor of `arena_cache` query values) - #155131 (Stabilize feature `uint_bit_width`) - #155147 (Stabilize feature `int_lowest_highest_one`) - #155174 (Improve emission of `UnknownDiagnosticAttribute` lint)

delegation: Track more precise spans for glob delegations The last commit also fixes a macro hygiene issue with `self` in delegations found in rust-lang#154002.

The span location of the last segment in the desugared path is inherited from the star symbol's span

…on body Instead of the last segment of the delegation path. `self` is something that introduced by the whole delegation item, not some specific part of it, and the last segment may need to have a different context for path resolution purposes.

rustbot · 2026-04-14T09:36:16Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-14T09:36:35Z

@bors r=jackh726

rust-bors · 2026-04-14T09:36:39Z

📌 Commit f001d78 has been approved by jackh726

It is now in the queue for this repository.

delegation: Track more precise spans for glob delegations The last commit also fixes a macro hygiene issue with `self` in delegations found in rust-lang#154002.

…uwer Rollup of 7 pull requests Successful merges: - #154049 (delegation: Track more precise spans for glob delegations) - #155134 (Replace custom trim_ascii_start with the standard library method) - #155235 (add the `fma4` x86 target feature) - #155218 (coroutines: Skip the closure signature annotation check for tainted bodies) - #155274 (limit duplicate-profiler-builtins test to targets that can do dynamic linking) - #155276 (`#[rustc_must_match_exhaustively]` detect let else) - #155281 (Revert "allow `windows-gnu` targets to embed gdb visualizer scripts")

Rollup merge of #154049 - petrochenkov:deleglobspan, r=jackh726 delegation: Track more precise spans for glob delegations The last commit also fixes a macro hygiene issue with `self` in delegations found in #154002.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 18, 2026

rustbot assigned jackh726 Mar 18, 2026

petrochenkov mentioned this pull request Mar 18, 2026

Select proper span for delegation, update span of child path segment if needed #154002

Closed

petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Mar 19, 2026

petrochenkov mentioned this pull request Mar 19, 2026

delegation: fix def path hash collision, add per parent disambiguators #153955

Open