Dont bail in error predicate unless self ty is error in new solver#150453
Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
Open
Dont bail in error predicate unless self ty is error in new solver#150453ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
ChayimFriedman2 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
ChayimFriedman2
changed the title
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Jan 6, 2026
compiler/rustc_next_trait_solver/src/solve/normalizes_to/mod.rs
Outdated
Show resolved
Hide resolved
Contributor
|
I think there's a pending comment, therefore switching to waiting on author. Feel free to request a review with @rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
less-err-in-solver
branch
from
fe9c130 to
1f3541d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
less-err-in-solver
branch
from
1f3541d to
ede6821
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #146602.
r? lcnr
@lcnr #146602 (comment)
Where do you want to put it?