Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 9, 2025

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 9, 2025
@RalfJung
Copy link
Member

RalfJung commented Dec 9, 2025

There's another job running Miri -- it's whatever job executes src/bootstrap/mk/Makefile.in. One of the "aux" jobs?

@Kobzol
Copy link
Member Author

Kobzol commented Dec 9, 2025

@bors try jobs=x86_64-gnu-aux

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 9, 2025
Use ubuntu:24.04 for the `x86_64-gnu-miri` job

try-job: x86_64-gnu-aux
@rust-bors
Copy link

rust-bors bot commented Dec 9, 2025

☀️ Try build successful (CI)
Build commit: fe506d4 (fe506d4b15cdecc482b05e445ecdb38e88c5de34, parent: c61a3a44d1a5bee35914cada6c788a05e0808f5b)

@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 10, 2025
Use ubuntu:24.04 for the `x86_64-gnu-miri` job
@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

@marcoieni Would you mind triggering the ghcr workflow manually, so we can test this without waiting for tomorrow? 😀

@marcoieni
Copy link
Member

done! https://github.com/rust-lang/rust/actions/runs/20093061858

@rust-bors
Copy link

rust-bors bot commented Dec 10, 2025

☀️ Try build successful (CI)
Build commit: 24659f6 (24659f67fce36a6362ed6172c24fa984df128117, parent: 2e667b0c6491678642a83e3aff86626397360af5)

@Kobzol
Copy link
Member Author

Kobzol commented Dec 10, 2025

r? @marcoieni

@Kobzol Kobzol marked this pull request as ready for review December 10, 2025 16:51
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2025
@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 10, 2025

📌 Commit 40891c7 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 10, 2025
bors added a commit that referenced this pull request Dec 11, 2025
Rollup of 4 pull requests

Successful merges:

 - #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
 - #149807 (Use ubuntu:24.04 for the `x86_64-gnu-miri` job)
 - #149850 (Remove "tidy" tool for `tests/rustdoc` testsuite)
 - #149867 (only resolve main in bin crates)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 11, 2025
…uwer

Rollup of 10 pull requests

Successful merges:

 - #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
 - #146584 (remove duplicated columns from `rustc_error_code::error_codes!`)
 - #148717 (Point at span within local macros even when error happens in nested external macro)
 - #148825 (Add SystemTime::{MIN, MAX})
 - #149565 (rustdoc: Add unstable `--merge-doctests=yes/no/auto` flag)
 - #149770 (Rename some issue-* tests)
 - #149807 (Use ubuntu:24.04 for the `x86_64-gnu-miri` job)
 - #149850 (Remove "tidy" tool for `tests/rustdoc` testsuite)
 - #149863 (Do not suggest moving expression out of for loop when hitting `break` from desugaring)
 - #149867 (only resolve main in bin crates)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 12, 2025
Rollup of 9 pull requests

Successful merges:

 - #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
 - #146584 (remove duplicated columns from `rustc_error_code::error_codes!`)
 - #148717 (Point at span within local macros even when error happens in nested external macro)
 - #149565 (rustdoc: Add unstable `--merge-doctests=yes/no/auto` flag)
 - #149770 (Rename some issue-* tests)
 - #149807 (Use ubuntu:24.04 for the `x86_64-gnu-miri` job)
 - #149850 (Remove "tidy" tool for `tests/rustdoc` testsuite)
 - #149863 (Do not suggest moving expression out of for loop when hitting `break` from desugaring)
 - #149867 (only resolve main in bin crates)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 12, 2025
Rollup of 9 pull requests

Successful merges:

 - #142380 (Put negative implementors first and apply same ordering logic to foreign implementors)
 - #146584 (remove duplicated columns from `rustc_error_code::error_codes!`)
 - #148717 (Point at span within local macros even when error happens in nested external macro)
 - #149565 (rustdoc: Add unstable `--merge-doctests=yes/no/auto` flag)
 - #149770 (Rename some issue-* tests)
 - #149807 (Use ubuntu:24.04 for the `x86_64-gnu-miri` job)
 - #149850 (Remove "tidy" tool for `tests/rustdoc` testsuite)
 - #149863 (Do not suggest moving expression out of for loop when hitting `break` from desugaring)
 - #149867 (only resolve main in bin crates)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 817c58a into rust-lang:main Dec 12, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 12, 2025
@Kobzol Kobzol deleted the miri-ubuntu-24.04 branch December 12, 2025 09:45
rust-timer added a commit that referenced this pull request Dec 12, 2025
Rollup merge of #149807 - Kobzol:miri-ubuntu-24.04, r=marcoieni

Use ubuntu:24.04 for the `x86_64-gnu-miri` job

Ralf asked for this in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Adding.20a.20C.2B.2B.20dependency.20to.20Miri.3F/with/560654845.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants